Conversation
blobcode
approved these changes
Nov 20, 2025
Collaborator
|
@WarrickT take a look if you get a chance - otherwise lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented flow for authenticating users in CLI:
config.jsonon CLI start.AppContext.mist auth login.mist auth loginnow opens browser and waits for user to input token, we call API (mocked right now) for long lived token and store it inAppContextand updateconfig.json.AppContextis binded to Kong to make accessible in all commands for future API calls.Notes:
authURLcurrently is placeholder, needs to be updated to login site.getLongLivedTokenneeds to call auth API.