feat(activation): drop the Claude-only early-stop restriction, pin coder-eval 0.9.1 - #2352
Conversation
…der-eval 0.9.1 coder-eval 0.9.1 extends cooperative early stop to the codex and antigravity agents, so an armed activation run no longer hard-errors at resolution under --type codex / --type antigravity. Bump the pin and delete the stale "must add -D run_limits.stop_early=false" instructions from the activation experiment and docs. Unarmed runs stay documented as the authoritative source for precision.
|
Claude finished @mohsen-uipath's task in 1m 55s —— View job PR Review: feat(activation): drop the Claude-only early-stop restriction, pin coder-eval 0.9.1
SummaryBumps Change-by-Change Review1.
|
| Area | Status | Notes |
|---|---|---|
| Frontmatter | N/A | No skill frontmatter changed |
| E2E Tests | OK | No test tasks modified — comment-only changes |
| Skill Body | N/A | No skills changed |
| References & Assets | OK | All relative links resolve (tasks/activation/README.md ✓) |
| Repo Hygiene | OK | No secrets, no cross-skill refs, changes scoped to tests/ |
Issues for Manual Review
None found. The PR is scoped to documentation and a version pin — no behavioral changes to verify beyond confirming coder-eval 0.9.1 supports early-stop on codex/antigravity (verified per the PR description's live-run evidence).
Conclusion
Clean, well-scoped PR. One Low nit: the comment at tests/experiments/activation.yaml:34 still singles out codex/antigravity for unarmed runs, which is the restriction being lifted. Otherwise, approve.
Code Review SummaryReviewed with Gemini 3.1 Pro + GPT-5.3-Codex in parallel, plus an Opus sub-agent. The central claim was also verified directly against the coder_eval source. Premise verified. coder_eval Critical / HighNone. Medium
Low
Blast radius — worth a line in the PR description
Risk is low: 0.9.0 → 0.9.1 is one feature commit touching Positive observations
OverallCorrect, well-scoped, and the premise checks out against upstream source. The one substantive defect is the 🤖 Generated with Claude Code |
uipreliga
left a comment
There was a problem hiding this comment.
Fix what you agree with and 🚢
…ording, comment reflow
|
Thanks for the thorough review
Declined as out of scope of this PR: version-literal templating (will file a follow-up) and the README dedup (two audiences; the Codex reviewer agreed). |
What
coder-eval 0.9.1 (UiPath/coder_eval#64) extends cooperative early stop to the
codexandantigravityagents. Before it, an armed activation run on those harnesses hard-errored at resolution (EarlyStopConfigError), forcing unarmed runs at ~2-3x cost — or no run, hence no suite aggregates and noActivation: NN% avg recallline in their nightly reports.tests/.coder-eval-version0.9.0→0.9.1— only functional change; drives the CLI wheel AND theghcr.io/uipath/coder-eval-agentimage tag across the consuming workflows. 0.9.1 wheel + image confirmed published: the full smoke suite passed on this PR under the new pintests/experiments/activation.yamlHARNESS CONSTRAINTcomment; comment version floor>= 0.8.10→>= 0.9.1; parsed YAML byte-identical to maintests/README.md>= 0.9.1tests/tasks/activation/README.md>= 0.8.10→>= 0.9.1+ name the below-floor failure (EarlyStopConfigError); unarmed-run note → "optional for routine checks, required for authoritative precision"tests/scripts/activation_gate.py>= 0.8.10floor →>= 0.9.1(review finding)Claude path untouched:
stop_early: true,stop_when: auto,max_turns: 3unchanged; experiment resolves to the identical task.Verification
coder-eval plan-valid under 0.9.1; armed activation resolves on all three harnesses (hard error on 0.9.0); no tracked text still claims early stop is Claude-only.gpt-5.6-terra): zeroEarlyStopConfigError, zero crashes/retries; 22 positives pass-stopped at turn 1 (score 1.0), 1 misfire fail-stopped correctly, negative ran to cap and passed; suite.json with per-skill P/R/F1 produced.gemini-3.5-flash): armed = 24/24 SUCCESS, all 23 positives pass-stopped at turn 1, 33 tool calls, ~$0.19, ~7.5s/row. Unarmed = 430 tool calls, ~$8.97, and 8 rows ERRORed on the experiment's 120s turn timeout — armed mode is what keeps the suite inside its limits on this harness, not just cheaper.total_token_usage: null(interrupt lands before the first usage-bearing message). Cost reporting only; verdicts/metrics unaffected. Claude records fully.Nightly dry-run
UiPath.Coder_Eval.Nightlyrun 20260729.17:harness=codex,model=gpt-5.6-terra,dryRun=true,skillsRef= this branch (6eb85b42), pin → 0.9.1. Mirrors reference run 12799116 (claude-code) with only branch + harness changed.EarlyStopConfigError. 24 rows: 21 pass-stopped atsdk_turn=1 tool_call=1, 2 fail-stopped at turn 1 on genuine misfires (uipath-functions-016,uipath-review-030, score 0.957), negative ran to cap. All three stop polarities exercised.skill-activation pass_rate=91.7% (22/24) gate=PASS— the aggregates theActivation:line derives from now exist for codex.Activation: 0% avg recall across 24 skills— the claude reference run shows the identical 0% next to a 100% rollup, so it is a composer bug in the external runner, independent of this change and harness. Flagged to the runner owner.Notes
-D run_limits.stop_early=falsefor codex/antigravity activation (coordinated separately).