free function serialization DSL#32
Conversation
|
Example usage (replacing serialization_demo_utils): We can serialize directly from seraphis types non-intrusively and don't need all the extra types and boilerplate eventually |
|
That should make things much easier. Thanks. |
|
You should parallel-PR this to the monero repo. |
src/serialization/serialization.h
Outdated
There was a problem hiding this comment.
I don't understand what this does, other than it allows the macro to be used outside of a class scope. Presumably that is the goal here?
There was a problem hiding this comment.
Yes, that's the current design goal with the Seraphis lib AFAIK: separate class definitions and their serialization.
src/serialization/serialization.h
Outdated
There was a problem hiding this comment.
I agree that the comment needs some fixing - the goal is to allow a standalone function in a cpp or something? Difficult to say without any example uses.
There was a problem hiding this comment.
There's some sample uses in an earlier comment in this thread. Should I put it into the code?
d79a5d1 to
394b18e
Compare
394b18e to
2ca414a
Compare
|
Fixed comments, thanks @UkoeHB |
Useful for PR #25