Vika_task2_find_the_cheapest_book - #64
Open
victoriazubyk wants to merge 1 commit into
Open
Conversation
Owner
|
It's not clear from the name of pull request what it is about. |
UkrainianEngineer
requested changes
Nov 21, 2018
| {'name': 'Harry Potter','price': 1300}, | ||
| {'name': 'Fluent Python','price': 650}] | ||
|
|
||
| val=[] |
There was a problem hiding this comment.
Please try to use spaces, new lines, etc. according to PEP 8 recommendations:
https://www.python.org/dev/peps/pep-0008/
|
|
||
| for elem in books: | ||
| for key,value in elem.items(): | ||
| if key=='price': |
There was a problem hiding this comment.
Please fix spaces.
Why do you need all prices in one list?
Isn't it possible to add price, name in one loop? Just to avoid moving through the list twice?
|
|
||
| m=min(val) | ||
|
|
||
| for elem in books: |
There was a problem hiding this comment.
It's a bad idea to iterate through the same list twice.
Please try to fix this logic somehow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add task 2