fix(site-exporter): enqueue Import Site uploader - #1690
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe Sites page script loader now accepts the WordPress-generated admin hook and the legacy submenu hook. A regression test verifies media-editor registration and the delegated ZIP-upload handler for the actual Sites admin hook. ChangesSites page script loading
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔨 Build Complete - Ready for Testing!📦 Download Build Artifact (Recommended)Download the zip build, upload to WordPress and test:
🌐 Test in WordPress Playground (Very Experimental)Click the link below to instantly test this PR in your browser - no installation needed! Login credentials: |
|
Performance Test Results Performance test results for a106b0f are in 🛎️! |
Summary
Cause
Verification
aidevops.sh v3.32.209 plugin for OpenCode v1.18.9 with gpt-5.6-terra Merged via PR #1690 to main. |
Summary
admin_page_wp-ultimo-siteswp-ultimois registered as an admin-menu parent#wu-upload-zip-btnhandlerCause
wp-ultimois an admin-bar parent rather than a registered WordPress admin-menu parent on the affected Network Admin page. WordPress therefore generatesadmin_page_wp-ultimo-sites, while the importer previously accepted onlywp-ultimo_page_wp-ultimo-sites; the media library and delegated click handler were never loaded.Verification
php -l inc/site-exporter/class-site-exporter.phpphp -l tests/WP_Ultimo/Site_Exporter_Test.phpvendor/bin/phpcs --standard=.phpcs.xml.dist inc/site-exporter/class-site-exporter.php tests/WP_Ultimo/Site_Exporter_Test.phpvendor/bin/phpstan analyse --configuration=phpstan.neon.dist --no-progress inc/site-exporter/class-site-exporter.php tests/WP_Ultimo/Site_Exporter_Test.phpaidevops.sh v3.32.209 plugin for OpenCode v1.18.9 with gpt-5.6-terra
Summary by CodeRabbit
Bug Fixes
Tests