GH#1694: use product fixture helper

[superdav42]

Resolves #1694

---

aidevops.sh v3.32.227 plugin for OpenCode v1.18.9 with gpt-5.6-terra

Summary by CodeRabbit

• Tests
  • Improved coverage for custom plan swaps by validating network product creation and explicitly checking for errors.
  • Updated related test documentation for consistency.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3eb2ac0a-428e-4bc2-97e2-35bd3faf4198

📥 Commits

Reviewing files that changed from the base of the PR and between 6fffbf6 and 23bfac2.

📒 Files selected for processing (1)

• tests/WP_Ultimo/Models/Membership_Test.php

---

📝 Walkthrough

Walkthrough

The custom plan swap test now creates its network product with wu_create_product(), skips validation through the helper input, and asserts that creation succeeds. A related test comment now capitalizes “Renew.”

Changes

Membership test fixture

Layer / File(s)	Summary
Use the product creation helper tests/WP_Ultimo/Models/Membership_Test.php	The custom network product fixture uses wu_create_product() with skipped validation and checks that the result is not a WP_Error. A related comment changes “renew” to “Renew”.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• Ultimate-Multisite/ultimate-multisite#1693: Introduced the custom plan swap test updated by this change.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: using the product fixture helper.
Linked Issues check	✅ Passed	The changes replace manual product construction with wu_create_product(), pass skip_validation, and assert WP_Error as required by issue #1694.
Out of Scope Changes check	✅ Passed	The changes remain within issue #1694 scope, including the related docblock comment correction.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feature/auto-20260805-170437-gh1694

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

• Build: ultimate-multisite
• ⬇️ Download from GitHub Actions
• ⬇️ Download without Github Account (nightly.link)

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

[superdav42]

Completion Summary

• What: Replaced the custom-plan test fixture with the persisted product helper.
• Issue: Review followup: PR #1693 — feat: support custom plans in membership renewals #1694
• Files changed: tests/WP_Ultimo/Models/Membership_Test.php
• Testing: PHPCS and the targeted membership swap PHPUnit test passed.
• Key decisions: Passed skip_validation through the helper to preserve the custom product type fixture behavior, and corrected a pre-existing docblock lint failure found by the scoped check.

---

aidevops.sh v3.32.227 plugin for OpenCode v1.18.9 with gpt-5.6-terra spent 5m and 102,539 tokens on this as a headless worker.

---

Merged via PR #1695 to main.
Merged by deterministic merge pass (pulse-wrapper.sh).

[github-actions]

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

• Build: ultimate-multisite
• ⬇️ Download from GitHub Actions
• ⬇️ Download without Github Account (nightly.link)

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password