Unwrap the boundary-conditions note, and an editing pass - #44
Merged
Merged
Conversation
The prose is joined onto one line per paragraph, so a one-word change no longer reflows a block and shows a dozen touched lines in the diff. Everything whose line breaks carry meaning is untouched: front matter, fenced blocks and directives, display maths, tables, HTML, headings, and list structure. 721 lines to 415. Verified rather than assumed: the markdown word stream was byte-identical across the unwrap, as were the fenced blocks, table rows, headings, display-maths blocks and links, and the archival PDF built from both versions rendered the same 6261 words over the same 13 pages. Two accidental trailing-double-space hard breaks went, one of them mid-sentence after a comma. On top of that, an editing pass: lighter phrasing through the opening and the classical-strategy paragraph, and four typos (a doubled "time", a capitalised "Imposing" mid-sentence, and double spaces around two equation references). Two claims are corrected rather than reworded. The locking figure's caption said the node-normal panel "converges towards the exact solution", which one figure at one resolution cannot show, and before that it said the panel WAS the exact solution, which overstates a numerical solve; it now says it matches to plotting accuracy at this resolution. The left panel is genuinely the analytic velocity substituted at the nodes, so "exact solution" is right for that one. And the finding about the facet normal is restored in plainer terms -- the velocity error does not approach zero under refinement -- with a pointer to the sweep in stress.py that measures it. Underworld development team with AI support from Claude Code
Contributor
|
Preview Or the whole site. Built from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prose is joined onto one line per paragraph, so a one-word change no longer
reflows a block and shows a dozen touched lines in the diff. 721 lines to 415.
Everything whose line breaks carry meaning is untouched: front matter, fenced
blocks and directives, display maths, tables, HTML, headings, and list
structure, with each item on its own line and continuations folded in.
Verified, not assumed. The markdown word stream was byte-identical across
the unwrap, as were the fenced blocks, table rows, headings, display-maths
blocks and links. The archival PDF was then built from both versions and the
rendered text compared: the same 6261 words in the same multiset, over the same
13 pages. Two accidental trailing-double-space hard breaks went, one of them
mid-sentence after a comma.
On top of that, an editing pass — lighter phrasing through the opening and the
classical-strategy paragraph — and four typos: a doubled "time", a capitalised
"Imposing" mid-sentence, and double spaces around two equation references.
Two claims corrected
The locking figure's caption said the node-normal panel "converges towards the
exact solution", which one figure at one resolution cannot show; before that it
said the panel was the exact solution, which overstates a numerical solve.
It now says it matches to plotting accuracy at this resolution. The left panel
is genuinely the analytic velocity substituted at the nodes —
truth.data[:] = _exact.evaluate("velocity", truth.coords)— so "exactsolution" is the right name for that one.
The finding about the facet normal is restored in plainer terms: the velocity
error does not approach zero under refinement, with a pointer to the
stress.py lockingsweep that measures it across five cell sizes.Checked
pixi run validateclean over 58 articles; the archival PDF builds;pixi run check-stylereports one hint (six not-X-but-Y constructions at 1.1per 1000 words, down from nine before the editing pass).
Two things left deliberately, both the author's call: line 63 is the one
paragraph that leans on its heading ("### 1. A direct penalty" → "This
could not be more simple"), and the
stress.py lockingsweep also shows theleak reading ~1e-5 while the answer is wrong — a sharper version of the note's
own argument, held back as paper material rather than note material.
Underworld development team with AI support from Claude Code