Skip to content

docs: add pipeline attestation verification gates#1373

Open
catcherintheroad-hub wants to merge 1 commit into
UnitOneAI:mainfrom
catcherintheroad-hub:improve/pipeline-attestation-verification
Open

docs: add pipeline attestation verification gates#1373
catcherintheroad-hub wants to merge 1 commit into
UnitOneAI:mainfrom
catcherintheroad-hub:improve/pipeline-attestation-verification

Conversation

@catcherintheroad-hub
Copy link
Copy Markdown

Created from review issue: #1372

Summary

  • Add deployment-time attestation verification checks to CICD-SEC-9.
  • Require digest binding, issuer/certificate identity constraints, source and builder provenance checks, and production enforcement evidence.
  • Add an attestation verification output table and edge-case fixtures for mutable tags, unconstrained verification, admission enforcement, and multi-arch images.

Validation

  • git diff --check
  • Markdown fence/non-ASCII sanity check
  • Reference URL checks for SLSA, Sigstore cosign verification, and GitHub artifact attestations

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cf427f66fe

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

predicateType: https://slsa.dev/provenance/v1
```

**Expected result:** Pass for the attestation verification portion of CICD-SEC-9 when paired with digest-based deployment.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Downgrade the incomplete policy fixture from pass

For policy-controller configurations like this fixture, the attestations block only requires a matching SLSA predicate type; without an attestation policy it does not check the SLSA predicate's source repository, workflow ref/commit, or builder identity that the skill now requires. Marking this as a Pass can train reviewers to credit production admission policies that still allow provenance from the wrong source or builder, so this case should remain Partial unless those predicate checks are added.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant