Skip to content

fix: relax over-strict discount applied[] count/position assertions #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XiaolongZhang-TT wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: relax over-strict discount applied[] count/position assertions #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions business_logic_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,12 +300,14 @@ def test_multiple_discounts_accepted(self):
discounted_checkout, expected_price, expected_discount=expected_discount
)

# Verify both applied discounts are present
# Verify both submitted codes are present in the applied list. The applied
# list also carries any automatic discounts (discount.md: applied contains
# code-based + automatic), so assert membership rather than an exact count.
discounts_data = getattr(discounted_checkout, "discounts", {})
discounts_obj = (
discount.DiscountsObject(**discounts_data) if discounts_data else None
)
self.assertTrue(discounts_obj and len(discounts_obj.applied) == 2)
self.assertTrue(discounts_obj and discounts_obj.applied)
applied_codes = [d.code for d in discounts_obj.applied]
self.assertIn(valid_code_1, applied_codes)
self.assertIn(valid_code_2, applied_codes)
Expand Down Expand Up @@ -337,13 +339,16 @@ def test_multiple_discounts_one_rejected(self):
discounted_checkout, expected_price, expected_discount=expected_discount
)

# Verify only one applied discount is present
# Verify the valid code is present in the applied list. The applied list
# also carries any automatic discounts, so assert membership rather than an
# exact count or a fixed position (automatic discounts have no code).
discounts_data = getattr(discounted_checkout, "discounts", {})
discounts_obj = (
discount.DiscountsObject(**discounts_data) if discounts_data else None
)
self.assertTrue(discounts_obj and len(discounts_obj.applied) == 1)
self.assertEqual(discounts_obj.applied[0].code, valid_code)
self.assertTrue(discounts_obj and discounts_obj.applied)
applied_codes = [d.code for d in discounts_obj.applied]
self.assertIn(valid_code, applied_codes)

def test_fixed_amount_discount(self):
"""Test that a fixed-amount discount code decreases the total correctly.
Expand Down
Loading