Allow anyOf and an open expansion of schema overlays ontop of 655 - #705
Open
raginpirate wants to merge 1 commit into
Open
Allow anyOf and an open expansion of schema overlays ontop of 655#705raginpirate wants to merge 1 commit into
raginpirate wants to merge 1 commit into
Conversation
damaz91
added
status:needs-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A small tweak over #655 which makes it extensible for payment handlers to drop-in schema expansions of ucp.request_constraints.
With this... I think we have a great final answer:
Shape example with payments: https://gist.github.com/raginpirate/29a5f929d6eb6d5686d6c081560e030b
Net:
│ │ #655 │ synthesis │
│ malformed declared keywords │ catches │ catches │
│ unrecognised keys │ rejects │ accepts — needs a lint
│ discrimination / branching. │ impossible │ native │
│ per-variant narrowing │ impossible │ native
│ handler domain keys │ impossible │ native
│ the #288 use case │ unsatisfiable │ works