Skip to content

Conversation

@villevsv-upcloud
Copy link
Contributor

No description provided.

@villevsv-upcloud villevsv-upcloud requested a review from scop July 22, 2025 08:04
@villevsv-upcloud villevsv-upcloud requested a review from a team as a code owner July 22, 2025 08:04
url = https://github.com/UpCloudLtd/upcloud-python-api
packages=['upcloud_api', 'upcloud_api.cloud_manager']
license = MIT
license_files = []
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes issue with twine, pypa/twine#1216 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know if it makes much of a difference, but I suppose we could add the actual license file here too.

Suggested change
license_files = []
license_files = LICENSE.txt

This syntax is untested, but I suppose it's the correct one per https://setuptools.pypa.io/en/latest/userguide/declarative_config.html#specifying-values. packages above uses something else that doesn't seem to be noted in the config spec.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to trigger the original issue, see https://github.com/UpCloudLtd/upcloud-python-api/actions/runs/16443800646/job/46470548059. Also tried license_files = ['LICENSE.txt'] and license_files = 'LICENSE.txt' with no success.

@villevsv-upcloud villevsv-upcloud merged commit 798073e into main Jul 23, 2025
18 checks passed
@villevsv-upcloud villevsv-upcloud deleted the chore/bump-python-dependencies branch July 23, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants