Skip to content

fix: update proposals and assignment columns#1526

Open
TCMeldrum wants to merge 7 commits into
developfrom
1602-update-fap-proposals-and-assginment-columns
Open

fix: update proposals and assignment columns#1526
TCMeldrum wants to merge 7 commits into
developfrom
1602-update-fap-proposals-and-assginment-columns

Conversation

@TCMeldrum

@TCMeldrum TCMeldrum commented May 21, 2026

Copy link
Copy Markdown
Contributor

Closes UserOfficeProject/issue-tracker#1602

Description

This PR updates the proposals and assignment columns in the FapProposalsAndAssignmentsTable component.

Motivation and Context

The update is necessary to provide a more comprehensive view of proposals and assignments data. This will make the data more informative and easier to understand for users.

Changes

  1. Added a new column for 'Principal Investigator', which displays the full name of the proposer and allows custom sorting.
  2. Added custom sorting to 'Reviewers' and 'Reviews' columns to handle the number of reviewers and reviews respectively.
  3. Enabled the column button and default expanded options for better table customization and visibility.
  4. Updated the getFapProposals GraphQL query to fetch firstname, lastname, and preferredname of the proposer.

How Has This Been Tested?

Fixes Jira Issue

https://jira.ess.eu//browse/

Depends On

Tests included/Docs Updated?

  • I have added tests to cover my changes.
  • All relevant doc has been updated

@TCMeldrum TCMeldrum requested a review from a team as a code owner May 21, 2026 10:52
@TCMeldrum TCMeldrum requested review from Bhaswati1148 and removed request for a team May 21, 2026 10:52
@TCMeldrum TCMeldrum marked this pull request as draft May 22, 2026 09:39
@TCMeldrum TCMeldrum marked this pull request as ready for review June 8, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PI name to FAP reviews page (without org)

2 participants