fix: column sort in experiments table#1576
Open
shivoomiess wants to merge 9 commits into
Open
Conversation
shivoomiess
requested review from
ChongJiaChua,
jekabs-karklins and
yoganandaness
and removed request for
a team and
ChongJiaChua
shivoomiess
changed the title
shivoomiess
changed the title
shivoomiess
changed the title
yoganandaness
requested changes
Jun 15, 2026
| "build": "npm run build:validation && npm run generate:uows && rm -rf ./build && tsc", | ||
| "postinstall": "npm run build:validation", | ||
| "dev": "docker compose up -d --remove-orphans && ts-node-dev -r tsconfig-paths/register --respawn -T ./index.ts", | ||
| "dev": "docker compose up -d --remove-orphans && ts-node-dev --inspect=9229 -r tsconfig-paths/register --respawn -T ./index.ts", |
Contributor
There was a problem hiding this comment.
Do we need to update readme about this? @jekabs-karklins
Contributor
There was a problem hiding this comment.
I think we should not add it here, because we already have the "debug" script. Does that work for you @shivoomiess
Collaborator
Author
There was a problem hiding this comment.
I think that runs a separate instance of the frontend dev server while reusing existing docker containers? Haven't tried using the debug script separately; we could:
- either add a port number for the inspect in
debug - or make the dev server debuggable (should be fine since we're already in dev?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue of column sorting not working properly in the Experiments Table.
Motivation and Context
The column sorting feature in the Experiments Table was not functioning as expected, leading to a less intuitive and potentially confusing user experience. This fix is necessary to ensure that users can sort data in a logical and predictable manner, improving the usability of the table.
Changes
devscript was updated to include the--inspectflag, allowing for easier debugging.ExperimentDataSource.tsfile was updated to include a map of fields that can be sorted. This provides explicit control over which columns can have their sorting functionality enabled.experiments.cy.tse2e test file was updated to include tests for the sorting functionality of each column in the visit table. This ensures that our sorting feature works as expected in the future.How Has This Been Tested?
Fixes Jira Issue
https://jira.ess.eu//browse/SWAP-5630
Depends On
Tests included/Docs Updated?