feat: links to user, proposal, FAP from Experiments and Proposals table#1593
Open
shivoomiess wants to merge 10 commits into
Open
feat: links to user, proposal, FAP from Experiments and Proposals table#1593shivoomiess wants to merge 10 commits into
shivoomiess wants to merge 10 commits into
Conversation
Add a generic RoleBasedLink wrapper that resolves its destination from the current user's role. Use it in the experiments table so a user officer's proposal-id link opens the officer proposal modal, carrying a `from` param so closing the modal returns to the originating page. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
shivoomiess
requested review from
ellen-wright,
jekabs-karklins and
yoganandaness
and removed request for
a team and
ellen-wright
Add a generic RoleBasedLink wrapper that resolves its destination from the current user's role. Use it in the experiments table so a user officer's proposal-id link opens the officer proposal modal, carrying a `from` param so closing the modal returns to the originating page. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
shivoomiess
force-pushed
the
SWAP-5403-links
branch
from
e70b01c to
c8d3b9a
Compare
…ffice-core into SWAP-5403-links
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces links to user, proposal, and FAP from the Experiments and Proposals tables.
Motivation and Context
This modification is required to enhance navigation and user experience by allowing users to navigate directly to related pages (user, proposal, FAP) from the Experiments and Proposals tables.
Changes
RoleBasedLinkthat renders links based on user roles.ExperimentsTable.tsx, added links to the proposal ID.ProposalTableOfficer.tsx, added links to Principal Investigator, Call, Instrument, and FAP fields.How Has This Been Tested?
Fixes Jira Issue
https://jira.ess.eu//browse/SWAP-5403
Depends On
Tests included/Docs Updated?