feat: bulk update roles#1596
Open
TCMeldrum wants to merge 3 commits into
Open
Conversation
…ffice-core into bulk-roles-assignments
ACLay
reviewed
Jun 26, 2026
Comment on lines
+476
to
+479
| addUsersRoles(userIds: number[], roleIds: number[]): Promise<boolean> { | ||
| throw new Error('Method not implemented.'); | ||
| } | ||
| removeUsersRoles(userIds: number[], roleIds: number[]): Promise<boolean> { |
Contributor
There was a problem hiding this comment.
Mainly thinking for consistency's sake, would it be worth adding async to the method definitions here?
| cy.contains('Assign Roles').click(); | ||
| }); | ||
|
|
||
| it.only('Officer can bulk assign roles to users', function () { |
Contributor
There was a problem hiding this comment.
Is this meant to be it.only() instead of it()?
Comment on lines
+13
to
+16
| //New query for user with roles | ||
| //Make sure offset is like max 10 | ||
| // Only like 3 calls to uows or something | ||
| // Check performace |
Contributor
There was a problem hiding this comment.
This feels like an in development TODO. If it was addressed, is it meant to be here still?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented bulk update functionality for user roles.
Motivation and Context
This change is required to enable the bulk assignment and removal of roles to multiple users at once, improving the efficiency of user management tasks.
Changes
addUsersRolesandremoveUsersRoles) to handle bulk operations.PostgresUserDataSourceandStfcUserDataSourceclasses.addRolesToUsersandremoveRolesFromUsers) inUserMutationsto expose these new functionalities to the API.How Has This Been Tested?
Fixes Jira Issue
https://jira.ess.eu//browse/
Depends On
Tests included/Docs Updated?