feat: technique proposals page use tags#1601
Open
Scott-James-Hurley wants to merge 16 commits into
Open
Conversation
…rived role, lint changes
Scott-James-Hurley
changed the title
Scott-James-Hurley
requested review from
William-Edwards-STFC
and removed request for
a team
…OfficeProject/user-office-core into technique_proposals_changes
…OfficeProject/user-office-core into technique_proposals_changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes UserOfficeProject/issue-tracker#1554
Description
If the user is logged in as a derived User Officer role with tags assigned to it, they will only see calls and instruments, and in turn, proposals and techniques, that are associated with those tags on the technique proposals page. This allows for siloed User Officers, who can only see and edit technique proposals for their facility.
Motivation and Context
Another facility (Central Laser Facility) at STFC has expressed interest in using the technique proposals feature. A requirement is that ISIS and CLF User Officers should not be able to see entities (calls, instruments, proposals, etc) from the other facility. Currently, there is no way to limit what User Officers can see on the technique proposals page.
How Has This Been Tested
Added E2E tests
Fixes
Fix PR also fixes an issue where trying to create a derived role of certain roles would throw an error.
Changes
Tests included/Docs Updated?