Bump dependency rustyline to v17.0.1 - #12
Conversation
- Bump dependency rustyline-derive to v0.11.1 - shell creation now returns a result
|
You can optionally find my investigation notes for this here. |
- Minor changes to resolve lints
|
I'll be back to check out these PRs once I've recovered (I got sick during travel). I think regardless, merging #10 first makes a lot of sense so we can get checks on this change running. I think both of these PRs is likely very close to the finish line so you can probably expect a pair of LGTMs from me within the next few days once I'm in better shape. |
|
Awesome! Hope you feel better soon! |
| .map(|h| h.to_string()) | ||
| .collect::<Vec<String>>() | ||
| .join("\n\t"); | ||
| // A bit of a mouthful. We grab the underlying history of the shell, collect its elements |
There was a problem hiding this comment.
Regarding this change, I'm assuming that the API changed and rl.history() is no longer an iterator? If not, what's the rationale for this change? To be honest, I think I prefer it anyways, after having written more Rust since I first wrote shi, I have gotten far less interested in trying to concoct complex iterator chains 😅.
There was a problem hiding this comment.
I like using iterators, but yeah they can get complex.
They have removed iterator support for history now. You can find out in their source code here that they're still unsure how to implement iterator support back with their new changes.
2 participants
Closes #11.