Security hardening: Fix issues #272, #279, #281, #270#289
Merged
elizabetheonoja-art merged 1 commit intoApr 28, 2026
Merged
Conversation
…ility-Drip#281, Utility-Drip#270 - Utility-Drip#272: Harden pause/resume functionality against reentrancy attacks - Add reentrancy guards to pause_stream and resume_stream functions - Implement proper state update ordering before external calls - Add ReentrancyDetected error variant and ReentrancyGuard storage - Utility-Drip#279: Audit and sanitize all user-supplied byte arrays - Add comprehensive validation functions for Ed25519 signatures and public keys - Implement length and encoding correctness checks for all byte arrays - Add validation to meter registration, pairing, usage deduction, and nonce sync - Enhance tariff oracle with signature validation - Utility-Drip#281: Migrate legacy cryptographic hashing to native Soroban functions - Replace placeholder commitment function with proper cryptographic implementation - Enhance ZK proof verification using native Soroban crypto functions - Improve heartbeat signature verification with domain separation - Add proper Ed25519 signature verification in nonce sync - Utility-Drip#270: Add comprehensive fuzz testing for arithmetic overflows - Create flow_rate_overflow_fuzz.rs for stream flow rate overflow testing - Add debt_overflow_fuzz.rs for debt calculation overflow scenarios - Implement precision_overflow_fuzz.rs for precision factor overflow testing - Update fuzz Cargo.toml with new comprehensive test targets All changes maintain backward compatibility while significantly improving security.
|
@akordavid373 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harden the pause/resume functionality against reentrancy in stream top-ups #272: Harden pause/resume functionality against reentrancy attacks
Audit and sanitize all user-supplied byte arrays for length and encoding correctness #279: Audit and sanitize all user-supplied byte arrays
Migrate legacy cryptographic hashing functions to native Soroban crypto host functions #281: Migrate legacy cryptographic hashing to native Soroban functions
Add comprehensive fuzz testing for arithmetic overflows in flow-rate calculations #270: Add comprehensive fuzz testing for arithmetic overflows
All changes maintain backward compatibility while significantly improving security.
closes #272
closes #279
closes #281
closes #270