260822 - #450
Merged
Merged
Conversation
do_autoreconf() points LIBTOOLIZE at the toolchain copy whenever one exists. When the package being reconfigured is libtool itself, that is the previously installed libtool preparing its own successor: autoreconf runs it as 'libtoolize --copy --force', which replaces the unpacked tarball's m4/*.m4 with the installed - older - macros. Upgrading libtool 2.5.4 to 2.6.2 therefore fails on any build tree that already has 2.5.4 installed: configure.ac:155: error: LT_LANG: unsupported language: "Objective-C" m4/libtool.m4:824: LT_LANG is expanded from... 2.6.2's own macros support that language; 2.5.4's, which overwrote them, do not. The error names the new source and the old macros, so it reads as a defect in the package rather than a stale tool. A clean tree is unaffected, because no libtoolize exists at that point and the build container ships none - which is why CI cannot see this, and why it only ever hits an incremental build across a bump. Skip the export for libtool alone, reproducing the clean-tree condition. Other self-hosting autotools packages could in principle need the same treatment, but only libtool is known to overwrite its own inputs.
A project package.mk routinely sources the global one to inherit PKG_VERSION, PKG_URL and PKG_SHA256, adding only project-specific hooks - projects/ROCKNIX has 53 such packages. get_pkg_directory() prefers the project package, so PKG_DIR points at the project copy and calculate_stamp() hashes only that. The file carrying the version is therefore never hashed. Bumping the global recipe does not change the stamp, so the previous version stays built and installed with no error and no rebuild. It surfaces later as a version mismatch in an unrelated package: checking for GPG Error - version >= 1.56... no configure: error: libgpg-error is needed. after libgpg-error went to 1.61 globally while a tree kept 1.55. On one month-old tree, 35 packages were stale this way, openssl, glib and libfmt among them, all silently. Add get_global_pkg_directory() - get_pkg_directory() cannot answer this, since preferring the project package is its purpose - and include the result in the stamp. Packages without a project override are unaffected: the path added is already in the list and the existing sort -u discards it, so their stamps are byte-identical and they do not rebuild. Verified both ways against a real .cache_package_global: appending a comment to the global recipe leaves the libgpg-error stamp unchanged before this patch and changes it after, while libtool's stamp is identical with and without. Overridden packages rebuild once, which is the correction.
Update kernel configs/device documentation
This works around a situation discovered after flashing Retroid recovery images for the Retroid Pocket Mini V2 and then attempting to install the ROCKNIX ABL. The primary GPT partition table for the block device containing the ABL partitions is corrupt, and so they cannot be found. Adding 'gpt' to the kernel cmdline resolves this. After flashing the ROCKNIX ABL the primary partition table is no longer corrupt.
…ine-gpt SM8250: add 'gpt' to EXTRA_CMDLINE
amd64: wip am64 changes
GRUB: fix device selection for stock bl
steam: remove x86 Mesa driver overwrite
rocknix: remove freq functions for different archs
Remove upstreamed patches. Make a new patch dir "pre7.2" for the DualSense Edge patch, as it's in 7.2 now.
flycast: update flycast sa and lr to v2.7
linux: update H700 to kernel 7.2
config/functions: hash the global recipe a project package sources
config/functions: do not reconfigure libtool with installed libtoolize
Remove upstreamed patches. Remove the patch "a610 set highest_bank_bit=14 to match SoC DDR" as we get UBWC config from the UBWC ssot, as of 1924272b9ce1edc5694e6d112097fd51e821980e
linux: update SM6115 to kernel 7.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Additional Context
AI Usage
While ROCKNIX doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? YES | PARTIALLY | NO