Skip to content

docs(backlog): triage FIX-LIVE-DCS-FAILURES, close Feature Q L4 gap#23

Merged
davidp57 merged 2 commits into
developfrom
fix/live-dcs-failures-triage
Jul 12, 2026
Merged

docs(backlog): triage FIX-LIVE-DCS-FAILURES, close Feature Q L4 gap#23
davidp57 merged 2 commits into
developfrom
fix/live-dcs-failures-triage

Conversation

@davidp57

@davidp57 davidp57 commented Jul 12, 2026

Copy link
Copy Markdown
Member

Summary

  • Opens and closes the FIX-LIVE-DCS-FAILURES lot: the 10 (of 18) live-run failures from 2026-07-10 not already fixed by POST-FULLGAS-FIXES are all cross-scenario state contamination (same class as the already-documented F-120/F-121/F-122/F-123), not real bugs — a mission reload clears them, confirmed 48/48 green on two consecutive fresh live runs. No src/test changes needed.
  • Records the L4 pilotPassive confirmation for Feature Q's whole-vehicle Request Equipment menu (done live with David, UH-1H), which had merged with only headless L3 coverage.
  • Refreshes .backlog/README.md: REINTEGRATE-ORPHAN-TESTS and POST-FULLGAS-FIXES were merged but still listed as active/in-progress.

Test plan

  • python tools/integration-runner/run_scenarios.py --no-ai — 48/48 PASS, run twice for stability
  • L4 pilotPassive manual confirmation (Feature Q whole-vehicle spawn) — done live with David
  • Doc-only change otherwise; no src/ touched, no rebuild needed

🤖 Generated with Claude Code

Summary by Sourcery

Document resolution of the initial live DCS integration run failures and finalize the FIX-LIVE-DCS-FAILURES lot, while recording L4 validation for Feature Q and updating backlog status.

Enhancements:

  • Clarify CHANGELOG entry for the first live DCS run, noting that the remaining failures were due to cross-scenario state contamination and that a fresh mission reload yields 48/48 passing scenarios.
  • Capture L4 pilotPassive confirmation for Feature Q's whole-vehicle Request Equipment menu in the POST-FULLGAS-FIXES ticket history.
  • Add backlog documentation for the FIX-LIVE-DCS-FAILURES lot, including problem statement, triage ticket, and conclusions from the re-run.
  • Refresh .backlog/README.md to mark REINTEGRATE-ORPHAN-TESTS and POST-FULLGAS-FIXES as completed and to record the FIX-LIVE-DCS-FAILURES lot as pending merge.

Documentation:

  • Expand backlog and changelog documentation around the first live DCS run, its failures, and their resolution, plus Feature Q’s L4 coverage.

davidp57 and others added 2 commits July 12, 2026 21:44
The first live run (2026-07-10) surfaced 18 scenario failures never turned
into tickets; 8 are already fixed by POST-FULLGAS-FIXES as a side effect,
this opens a lot to triage the remaining 10. Also records the L4 pilotPassive
confirmation for Feature Q's whole-vehicle Request Equipment menu (done live
with David, UH-1H), which had merged with only headless L3 coverage. Backlog
index refreshed: REINTEGRATE-ORPHAN-TESTS and POST-FULLGAS-FIXES were merged
but still listed as active.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Fresh live run against the already-loaded mission (--no-ai, two consecutive
runs): 48/48 auto/auto-check scenarios PASS, including all 10 flagged in
ticket 01. Root cause is the same cross-scenario state contamination already
documented for F-120/F-121/F-122/F-123 in the 2026-07-10 run (shared
MenuManager/scheduler/probe-guard state across a long mission session) — a
mission reload clears it, no src or test change needed.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@sourcery-ai

sourcery-ai Bot commented Jul 12, 2026

Copy link
Copy Markdown

Reviewer's Guide

Documents the resolution of the first live DCS run failures lot, records L4 confirmation for Feature Q, and refreshes backlog metadata to reflect completed lots and the relationship between live-run failures and prior fixes.

Flow diagram for FIX-LIVE-DCS-FAILURES lot and related backlog lots

flowchart TD
  subgraph LiveRun_2026_07_10
    A[First_live_run 45_scenarios]
    B[18_failures]
  end

  B --> C[8_failures_fixed_by_POST_FULLGAS_FIXES]
  B --> D[10_failures_in_FIX_LIVE_DCS_FAILURES_lot]

  C --> E[Lot_POST_FULLGAS_FIXES_done]
  D --> F[Lot_FIX_LIVE_DCS_FAILURES_done]

  subgraph FreshLiveRun_2026_07_12
    G[Reload_mission_before_run]
    H[Run_tools_integration_runner_run_scenarios_py_no_ai]
    I[48_48_auto_auto_check_PASS]
  end

  F --> G
  G --> H
  H --> I

  E --> J[CLEANUP_LEGACY_DCS_TESTS_sibling_program]
  F --> J
Loading

File-Level Changes

Change Details Files
Clarified CHANGELOG entry for the first full live DCS run to document the count and disposition of failures after POST-FULLGAS-FIXES and the FIX-LIVE-DCS-FAILURES lot.
  • Updated narrative of the initial live run from "~13 remaining failures" to "18 failures total" with explicit breakdown of 8 fixed by POST-FULLGAS-FIXES and 10 handled by FIX-LIVE-DCS-FAILURES.
  • Recorded that the remaining 10 failures were cross-scenario state contamination cleared by a mission reload, yielding 48/48 green scenarios over two runs.
CHANGELOG.md
Captured L4 pilotPassive confirmation for Feature Q’s whole-vehicle Request Equipment menu and closed its L4 coverage gap in the backlog ticket.
  • Appended a note that the whole-vehicle option was confirmed live at L4 (pilotPassive) with date, aircraft, and menu path.
  • Explicitly stated that this closes the previously missing L4 coverage gap for the merged menu change.
.backlog/POST-FULLGAS-FIXES/tickets/01-fq-regression.md
Updated backlog README to mark FIX-LIVE-DCS-FAILURES as the current lot entry and move REINTEGRATE-ORPHAN-TESTS and POST-FULLGAS-FIXES to the completed lots section with concise summaries.
  • Replaced the REINTEGRATE-ORPHAN-TESTS line in the active lots table with a new entry for FIX-LIVE-DCS-FAILURES, describing the triage and outcome of the remaining live-run failures.
  • Added REINTEGRATE-ORPHAN-TESTS to the completed lots list with its original scope and PR reference.
  • Added POST-FULLGAS-FIXES to the completed lots list with a summary of its fixes and its role in resolving 8 of the 18 live-run failures.
.backlog/README.md
Introduced a new backlog lot directory for FIX-LIVE-DCS-FAILURES, documenting the triage ticket, failure analysis, and acceptance criteria for the live-run failures.
  • Created ticket 01 describing the triage of the 10 remaining live-run failures, their root cause as cross-scenario state contamination, and the operational takeaway to reload missions before full sweeps.
  • Listed the original failure scenarios from the 2026-07-10 run, including expected fixes or deferrals, and captured acceptance criteria for closing the lot.
  • Documented the context and workflow for re-running scenarios, inspecting logs, and deciding between src/test changes or deferrals.
.backlog/FIX-LIVE-DCS-FAILURES/tickets/01-triage-remaining-failures.md
Added a PRD for the FIX-LIVE-DCS-FAILURES lot to connect the first live-run failure set, the already-fixed scenarios, and the scope/non-goals of this triage effort.
  • Documented the problem statement for the initial live run’s 27/45 passes and 18 failures, and the need to convert the previously informal tracking into backlog tickets.
  • Enumerated the 8 failures already fixed by POST-FULLGAS-FIXES, noting they are verify-only in this lot.
  • Defined ticket 01 as the umbrella for triaging the remaining failures and clarified non-goals around legacy relic cleanup.
.backlog/FIX-LIVE-DCS-FAILURES/PRD.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@davidp57 davidp57 merged commit abb35a9 into develop Jul 12, 2026
5 checks passed
@davidp57 davidp57 deleted the fix/live-dcs-failures-triage branch July 12, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant