Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR ensures the Lua plugin download buttons in the docs trigger browser downloads with an explicit and correct filename, aligning the rendered HTML with the intended user-facing behavior. CI, external link handling, and documentation language migration are also adjusted per the description, though only the download attribute change is visible in the provided diff. Sequence diagram for explicit download filename on Lua plugin buttonsequenceDiagram
actor User
participant Browser
participant DocsServer
User->>Browser: click metal-farp.lua .md-button
Browser->>DocsServer: GET /downloads/CTLD_metalFarpScene.lua
DocsServer-->>Browser: 200 CTLD_metalFarpScene.lua
Browser->>Browser: apply download attribute metal-farp.lua
Browser-->>User: prompt save dialog with filename metal-farp.lua
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11
Summary
.luafiles todocs/downloads/for same-origin downloaddownload="plugin-name.lua"for correct filenamehooks.py) addstarget="ext-{id}" rel="noopener"to all external linksTest plan
.luadownload triggers file save with correct filenameSummary by Sourcery
Documentation: