Fix IMPA Hall gain sign and synchronize code defaults with vest.yaml (#624, #625) - #681
Merged
Merged
Conversation
…624, #625) - Correct IMPA Hall gain default from +2/15 to -2/15 (-0.1333 T/V) in ImpaProcessingConfig and _resolve_gain fallback to match hardware datasheet and vest.yaml (#624). - Synchronize max_normalized_rmse default to 0.15 across grade_impa_quality, process_impa, and process_impa_shot (#625). - Synchronize bz_radial_offset default to 0.01 m in process_impa and process_impa_shot (#625). - Remove unused and unread max_relative_noise threshold from TfWindowCriteria, _window_criteria, and vest.yaml (#625). - Update synthetic test fixtures to use canonical gain and add regression tests for code-to-YAML default parity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #624 and #625.
Summary of Changes
+2/15to-2/15(-0.13333333333333333T/V) inImpaProcessingConfig.gainand_resolve_gainfallback to match the DAQ wiring datasheet, docstrings, andvest.yaml.max_normalized_rmsedefault to0.15acrossgrade_impa_quality,process_impa, andprocess_impa_shotto matchvest.yamlquality gate.bz_radial_offsetdefault to0.01(m) inprocess_impaandprocess_impa_shotto reflect physical probe head geometry.TfWindowCriteria.max_relative_noiseparameter fromTfWindowCriteria,_window_criteria, andvest.yaml.test/test_impa_processing.pyto use canonical negative gain.test/test_impa_processing.pyandtest/test_impa_mapping.pyverifying code defaults and YAML-configured parity.