Skip to content

Fix IMPA Hall gain sign and synchronize code defaults with vest.yaml (#624, #625) - #681

Merged
HongSik-Yun-Fusion merged 1 commit into
mainfrom
fix/624-625-impa-defaults-gain-sign
Sep 9, 2026
Merged

Fix IMPA Hall gain sign and synchronize code defaults with vest.yaml (#624, #625)#681
HongSik-Yun-Fusion merged 1 commit into
mainfrom
fix/624-625-impa-defaults-gain-sign

Conversation

@HongSik-Yun-Fusion

Copy link
Copy Markdown
Contributor

Resolves #624 and #625.

Summary of Changes

  1. Gain Sign Discrepancy (The IMPA Hall gain default has the opposite sign to the configuration and the documentation #624):
    • Corrected canonical Hall gain default from +2/15 to -2/15 (-0.13333333333333333 T/V) in ImpaProcessingConfig.gain and _resolve_gain fallback to match the DAQ wiring datasheet, docstrings, and vest.yaml.
  2. Threshold & Offset Defaults (Three IMPA code defaults disagree with vest.yaml, and one configured threshold is never read #625):
    • Synchronized max_normalized_rmse default to 0.15 across grade_impa_quality, process_impa, and process_impa_shot to match vest.yaml quality gate.
    • Synchronized bz_radial_offset default to 0.01 (m) in process_impa and process_impa_shot to reflect physical probe head geometry.
  3. Unread Parameter Clean-up (Three IMPA code defaults disagree with vest.yaml, and one configured threshold is never read #625):
    • Removed unread and unused TfWindowCriteria.max_relative_noise parameter from TfWindowCriteria, _window_criteria, and vest.yaml.
  4. Test Suite:
    • Updated synthetic test fixtures in test/test_impa_processing.py to use canonical negative gain.
    • Added unit tests in test/test_impa_processing.py and test/test_impa_mapping.py verifying code defaults and YAML-configured parity.

…624, #625)

- Correct IMPA Hall gain default from +2/15 to -2/15 (-0.1333 T/V) in ImpaProcessingConfig and _resolve_gain fallback to match hardware datasheet and vest.yaml (#624).
- Synchronize max_normalized_rmse default to 0.15 across grade_impa_quality, process_impa, and process_impa_shot (#625).
- Synchronize bz_radial_offset default to 0.01 m in process_impa and process_impa_shot (#625).
- Remove unused and unread max_relative_noise threshold from TfWindowCriteria, _window_criteria, and vest.yaml (#625).
- Update synthetic test fixtures to use canonical gain and add regression tests for code-to-YAML default parity.
@HongSik-Yun-Fusion
HongSik-Yun-Fusion merged commit 2b8e887 into main Sep 9, 2026
10 checks passed
@HongSik-Yun-Fusion
HongSik-Yun-Fusion deleted the fix/624-625-impa-defaults-gain-sign branch September 9, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The IMPA Hall gain default has the opposite sign to the configuration and the documentation

1 participant