Align evaluate_solovev poloidal field orientation with COCOS conventions (#600) - #682
Merged
HongSik-Yun-Fusion merged 2 commits intoSep 9, 2026
Merged
Conversation
HongSik-Yun-Fusion
commented
Sep 9, 2026
HongSik-Yun-Fusion
commented
Contributor
- Add explicit cocos (and convention alias) parameter to evaluate_solovev, defaulting to VAFT_INTERNAL_COCOS = 11.
- Calculate poloidal field components using orientation factor k_sign = sigma_RphiZ * sigma_Bp from the convention, falling back to k_sign = -1 when cocos is None.
- Reconcile both orientation sign and 2*pi scaling in solovev_to_equilibrium across all COCOS conventions via convert_cocos.
- Update notebooks/analytic_solovev_equilibrium.ipynb to align with COCOS 11 orientation.
- Add unit tests for evaluate_solovev orientation families and solovev_to_equilibrium convention reconciliation.
…ons (#600) - Add explicit cocos (and convention alias) parameter to evaluate_solovev, defaulting to VAFT_INTERNAL_COCOS = 11. - Calculate poloidal field components using orientation factor k_sign = sigma_RphiZ * sigma_Bp from the convention, falling back to k_sign = -1 when cocos is None. - Reconcile both orientation sign and 2*pi scaling in solovev_to_equilibrium across all COCOS conventions via convert_cocos. - Update notebooks/analytic_solovev_equilibrium.ipynb to align with COCOS 11 orientation. - Add unit tests for evaluate_solovev orientation families and solovev_to_equilibrium convention reconciliation.
…r catalog CLI round-trip
HongSik-Yun-Fusion
deleted the
fix/600-solovev-poloidal-field-orientation
branch
September 9, 2026 02:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.