Skip to content

Conversation

@SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Sep 25, 2023

Прототип Scaffold

@SevereCloud SevereCloud added the no-stale Добавляет PR в исключения для автоматического закрытия label Sep 25, 2023
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 317.23 KB (0%)
JS (gzip) 96.79 KB (0%)
JS (brotli) 80.08 KB (0%)
JS import Div (tree shaking) 2.95 KB (0%)
CSS 277.22 KB (0%)
CSS (gzip) 36.13 KB (0%)
CSS (brotli) 28.6 KB (0%)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 30f151f:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

👀 Docs deployed

Commit 30f151f

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.09% ⚠️

Comparison is base (5c170b3) 81.18% compared to head (30f151f) 81.09%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5869      +/-   ##
==========================================
- Coverage   81.18%   81.09%   -0.09%     
==========================================
  Files         299      300       +1     
  Lines        9190     9200      +10     
  Branches     3121     3123       +2     
==========================================
  Hits         7461     7461              
- Misses       1729     1739      +10     
Flag Coverage Δ
unittests 81.09% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/vkui/src/components/Scaffold/Scaffold.tsx 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inomdzhon
Copy link
Contributor

inomdzhon commented Jul 17, 2025

Из-за того, что скролл будет не на <body> потеряется сохранения браузером положения. Но эта фича может быть не всем нужна. В доке компонента Scaffold нужно отметить это.

Прикрепил в описание схожий запрос #1064

UPD
Может поможет ScrollSaver #6011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-stale Добавляет PR в исключения для автоматического закрытия

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants