-
Notifications
You must be signed in to change notification settings - Fork 198
feat(adaptivity): move to density adaptivity prop #9334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
inomdzhon
wants to merge
2
commits into
master
Choose a base branch
from
imirdzhamolov/issue9015/feat/add-density-adaptivity-prop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(adaptivity): move to density adaptivity prop #9334
inomdzhon
wants to merge
2
commits into
master
from
imirdzhamolov/issue9015/feat/add-density-adaptivity-prop
+1,350
−953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b9de73 to
7087d0e
Compare
Contributor
size-limit report 📦
|
Contributor
e2e tests |
Contributor
Contributor
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9334/15b84d650d0018a7b5d4483bd77fc8386b0f5124/pkg/@vkontakte/vkui/_pkg.tgzCommit 15b84d6 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9334 +/- ##
==========================================
- Coverage 94.96% 94.76% -0.21%
==========================================
Files 436 436
Lines 11763 11854 +91
Branches 4329 4380 +51
==========================================
+ Hits 11171 11233 +62
- Misses 592 621 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SevereCloud
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
densityна заменуsizeX/sizeY#9015[ ] Дизайн-ревьюОписание
density(полный аналогsizeY) и заменилsizeYна него по всему репозиторию.sizeX="compact"заменил наviewWidth.MOBILEиsizeY="regular"заменил наviewWidth.SMALL_TABLETгде это возможно.Note
Скриншоты
На скриншотах оставил названия
sizeXиsizeY, чтобы не увеличивать кол-во измененных файлов и убедиться, что изменения обратно совместимы.Изменения
sizeXв CSS заменен на--viewWidth-smallTabletMinus/--viewWidth-smallTabletPlusв@mediaи наviewWidthSmallTabletMinus/viewWidthSmallTabletPlusв селекторах, а также в глобальных селекторахvkuiInternal. Исключение: селекторы вTappableзаменил на более семантичные.sizeYв CSS напрямую заменен наdensityв@mediaи в селекторах, а также в глобальных селекторахvkuiInternal.ComponentPlayground.tsxsizeXиsizeYперебиваются наviewWidthиdensityсоотвествено.**/*.e2e.tsxsizeYзаменён наdensity.sizeXпока оставил как есть.useAdaptivityConditionalRenderсоздана временная функциюgetAdaptivityConditionalRenderForSizeXCompact.useAdaptivityWithJSMediaQueriesсозданы временные функцииisSizeXCompactFallbackиisSizeXRegularFallback.Release notes
Улучшения
AdaptivityProvider: свойства
sizeXиsizeYтеперь@deprecated, используйтеdensityвместоsizeY,viewWidth={ViewWidth.MOBILE}вместоsizeX="compact"иviewWidth={ViewWidth.SMALL_TABLET}вместоsizeX="regular"Пример миграции