Repository navigation
Client-Side Hash code Retrieval fix - INVALID_DATA_BUFFER - #53
Open
AwazonDotCom wants to merge 2 commits into
Open
AwazonDotCom wants to merge 2 commits into
AwazonDotCom wants to merge 2 commits into
Conversation
Hashcode collection was only able to be collected by the host. The sv.request that clients would initiate ended up giving out the incorrect format. This change removes the extra step through the coop::chat_feed protocol and instead runs it through the base ToUtf8Extract system, forcing the command written and broadcasted to the clients to be formatted as its original file. INVALID_DATA_BUFFER now returns the actual information.
Author
Error before and after fix as stated as well. |
Adds in a guard to prevent the loss of items within the drive rack. Without it, each launch automatically removes every item once saved and reloaded. This guarantees that the mass removal guard isn't triggered when reload. It instead calls the same process from drive_payload_sync, making sure they maintain position. This also stops the save-record lane from rewriting the racks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hash code collection was only able to be collected by the host. The sv.request that clients would initiate ended up giving out the incorrect format.
This change removes the extra step through the coop::chat_feed protocol and instead runs it through the base ToUtf8Extract system, forcing the command written and broadcasted to the clients to be formatted as its original text format. This is why the host didn't have or encounter any issues with the command entry and collection, as the host never had to have the hash information sent through the ToUtf8 cleaner. INVALID_DATA_BUFFER now returns the actual information.