Skip to content

fix(publish-crate): scope package-name sed to [package] section only #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VrilLabs merged 2 commits into from
Jul 2, 2026
Merged

fix(publish-crate): scope package-name sed to [package] section only #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82dc09a
Initial plan
Copilot Jul 2, 2026
d2e1431
Fix: scope sed package-name normalization to [package] section only
Copilot Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/publish-crate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,17 @@ jobs:
# "helios" to "vrillabs-helios". Patch it in-place so all cargo commands
# below can use the canonical crates.io name unconditionally. This change
# is ephemeral and is never committed or pushed.
#
# The substitution is intentionally scoped to the [package] section via a
# sed address range (/^\[package\]/,/^\[/). This prevents the pattern from
# also matching the `name` field under [lib], which must remain "helios"
# (an unqualified Rust identifier). Per the official Cargo reference:
# https://doc.rust-lang.org/cargo/reference/cargo-targets.html
# "library target names cannot contain hyphens" — Cargo rejects any [lib]
# name that is not a valid Rust identifier, so "vrillabs-helios" is illegal
# there even though it is a valid [package] name on crates.io.
run: |
sed -i 's/^name = "helios"$/name = "vrillabs-helios"/' rs/helios/Cargo.toml
sed -i '/^\[package\]/,/^\[/{s/^name = "helios"$/name = "vrillabs-helios"/}' rs/helios/Cargo.toml

- name: Install Rust toolchain
uses: dtolnay/rust-toolchain@stable
Expand Down
Loading