fix: preserve Slides model routing across nested agents#81
Merged
Conversation
- inherit request and caller model wrappers in Slides planner and writer\n- route only verified Codex browser auth through Responses streaming\n- keep generic compatible, OpenRouter, LiteLLM, and Ollama transports intact\n- recover non-empty structured text from streamed helper output
nicko-ai
marked this pull request as ready for review
July 26, 2026 01:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Slides generation when nested planner and HTML-writer agents use an inherited or non-default model.
The previous implementation duplicated model setup across Insert and Modify flows. It could ignore
RunConfig.model, select an unrelated fallback, and classify generic OpenAI-compatible endpoints as Codex Responses. That could produce failed or empty Slides output.Changes
Validation
Remaining acceptance
Hosted checks will run on this PR. A credentialed live
gpt-5.4-miniInsert and Modify flow is still required before merge.This replaces the current-main-relevant parts of #68 without carrying forward its stale and conflicting changes.