fix(release): packaging script no longer wipes dist/ (keep the .dmg) - #11
Merged
Conversation
make-radioplugin.sh did `rm -rf dist`, which in the release pipeline deleted the standalone .app/.dmg built moments earlier by build-app.sh/make-dmg.sh — failing the checksum step and aborting the whole release (so the #10 merge cut no release). The script now only ensures dist/ exists and overwrites its own package, leaving the .dmg in place. The standalone app release is unchanged; the .radioplugin is purely an additional artifact alongside it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: the #10-merge release run failed (
shasum: LP-700-App-0.1.7.dmg: No such file or directory) and cut no release. Cause:make-radioplugin.shranrm -rf dist, deleting the standalone.app/.dmgthatbuild-app.sh/make-dmg.shhad just built, before the checksum/attach steps.Fix: the script now only
mkdir -p dist+ removes its own*.radioplugin, leaving the.dmgintact.The standalone app release is unchanged (still built + attached, exactly as before); the
.radioplugin/.appexis purely an additional artifact alongside the.dmg. Verified locally: a sentineldist/*.dmgsurvives the script whileLP700.radiopluginis produced. Merging this re-triggers the release and should publish v0.1.7 with both the.dmgand the.radioplugin.🤖 Generated with Claude Code