ci: codesign + staple the DMG, and staple the app - #14
Merged
Conversation
package-signed.sh now notarizes + staples the *app* before building the DMG (so
the bundle carries its ticket offline / once copied out), then codesigns the
DMG and notarizes + staples the DMG itself. Without the DMG codesignature
`spctl -a -t open` rejects it ("no usable signature") and a downloaded DMG can
prompt Gatekeeper on mount even though the app is notarized. Two notary
submissions; gated on secrets as before.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up hardening for the signed+notarized release (the original CI PR is already merged). Applies the same DMG-hardening proven on LP-100A v0.2.13.
Before this, the release notarized + stapled the DMG but never codesigned the DMG container, so
spctl -a -t openrejected it ("no usable signature") — a downloaded DMG could prompt Gatekeeper on mount even though the app is notarized. The app was also not individually stapled (weaker offline).Change (
package-signed.sh)Two notary submissions; gated on secrets as before; ad-hoc fallback unchanged.
Note
Recreated on a fresh branch off
main: the hardening commit was accidentally pushed onto the already-merged CI branch, so it never reachedmain. This PR carries that exact commit cleanly.🤖 Generated with Claude Code