style: merge data_types/src/types/* into data_types/src/types.vhd#543
Merged
LarsAsplund merged 4 commits intoVUnit:masterfrom Sep 20, 2019
Merged
style: merge data_types/src/types/* into data_types/src/types.vhd#543LarsAsplund merged 4 commits intoVUnit:masterfrom
LarsAsplund merged 4 commits intoVUnit:masterfrom
Conversation
Member
Author
|
@LarsAsplund, I updated this issue and I believe it is ready to merge.
EDIT I replied to myself.. the commit is automatically merged with master |
fd89519 to
1b6a8d3
Compare
LarsAsplund
reviewed
Sep 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there are two files with 5 lines each. When byte_vector is added in #507, there will be three. Apart from being short, the content is tightly related. As proposed in #507, a single
types_pkgpackage is defined, and all the types are put there.Moreover, as commented in #507, the definition of
byte_tis moved fromverification_components/**/memory_pkg.vhdto thisdata_types/**/types.vhd.Also, in #507,
type storage_mode_t is (internal, extfnc, extacc);is defined instring_ptr_pkg.vhd. This type is to be later used byinteger_vector_ptr_pkg.vhd(#476) andmemory_pkg.vhd(#470). Therefore, it makes sense to makebyte_tandstorage_mode_tavailable in a similar fashion.