Skip to content

Swift 4.2 - #102

Open
Bill-Niz wants to merge 4 commits into
Vaberer:masterfrom
Bill-Niz:swift-4.2
Open

Swift 4.2#102
Bill-Niz wants to merge 4 commits into
Vaberer:masterfrom
Bill-Niz:swift-4.2

Conversation

@Bill-Niz

Copy link
Copy Markdown

No description provided.

@garrefa garrefa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Great job man.
Quick question, why is the .ttf binary changed?

Best

@Grep5268

Copy link
Copy Markdown

Can this be merged if there are no issues? I am trying to update to swift 4.2.

@tmdude9586

Copy link
Copy Markdown

Any update on this? The changes look good to me based upon the renaming for swift 4.2

@jvbreen1

jvbreen1 commented Jan 5, 2019

Copy link
Copy Markdown
Contributor

@Vaberer Can this be merged? I can replicate this on my fork, but I'd like to use the main repository if I can in my projects.

@s2305

s2305 commented Jan 29, 2019

Copy link
Copy Markdown

Hello, why there is no merge for this pull request ? It would be so useful to have a new pod for swift version 4.2.
Thanks in advance.

@gengelha

Copy link
Copy Markdown

++ Would like to see this merged.

@Superbil

Superbil commented May 8, 2019

Copy link
Copy Markdown

I hope this pull-request can merged. Before that if you use cocoapods this config can use it.

pod 'Font-Awesome-Swift', :git => 'https://github.com/Bill-Niz/Font-Awesome-Swift', :branch => 'swift-4.2' 

BTW, fontAwesome is old need to update

@jvbreen1

jvbreen1 commented May 8, 2019

Copy link
Copy Markdown
Contributor

I'm going to guess this library is unmaintained. It hasn't been touched in two years. If someone has time, they could reach out to the maintainer about getting access. I can do so, but it might be a bit.

@waseefakhtar

Copy link
Copy Markdown

It would be awesome if we merged this now. Thanks @Bill-Niz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants