Skip to content

fix macos hardware acceleration issue #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ValentinRapp merged 3 commits into from
Jun 7, 2026
Merged

fix macos hardware acceleration issue #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6bd7509
fix
ValentinRapp Jun 7, 2026
fe7025c
Merge pull request #18 from ValentinRapp/fix-macos-hardware-acceleration
ValentinRapp Jun 7, 2026
a6ef2f5
changed version number
ValentinRapp Jun 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion electrobun.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export default {
app: {
name: "yafw",
identifier: "yafw.electrobun.dev",
version: "0.7.1",
version: "0.7.3",
},
build: {
// Vite builds to dist/, Electrobun copies from there into the bundle
Expand Down
25 changes: 22 additions & 3 deletions src/bun/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,25 @@ import { basename, dirname, extname, join } from "path";
import { homedir } from "os";
import { update } from "./updater";

const getBinaryPathAsync = async (name: "ffmpeg" | "ffprobe"): Promise<string> => {
if (process.platform === "darwin") {
const paths = [
`/opt/homebrew/bin/${name}`,
`/usr/local/bin/${name}`,
`/opt/local/bin/${name}`,
];
for (const p of paths) {
if (await Bun.file(p).exists()) {
return p;
}
}
}
return name;
}

const ffmpegPathPromise = getBinaryPathAsync("ffmpeg");
const ffprobePathPromise = getBinaryPathAsync("ffprobe");

const DEV_SERVER_PORT = 5173;
const DEV_SERVER_URL = `http://localhost:${DEV_SERVER_PORT}`;

Expand Down Expand Up @@ -125,7 +144,7 @@ const rpc = BrowserView.defineRPC<AppRPCType>({
];
console.log(`[FFmpeg] ffmpeg ${fullArgs.join(" ")}`);

const proc = Bun.spawn(["ffmpeg", ...fullArgs], {
const proc = Bun.spawn([await ffmpegPathPromise, ...fullArgs], {
stdout: "pipe",
stderr: "pipe",
});
Expand Down Expand Up @@ -192,7 +211,7 @@ const rpc = BrowserView.defineRPC<AppRPCType>({
console.log("[YAFW] probeVideo:", inputPath);
try {
const proc = Bun.spawn([
"ffprobe",
await ffprobePathPromise,
"-v", "error",
"-select_streams", "v:0",
"-show_entries", "stream=r_frame_rate,width,height,bit_rate,duration:format=duration",
Expand Down Expand Up @@ -231,7 +250,7 @@ const rpc = BrowserView.defineRPC<AppRPCType>({
detectHardwareAccelerators: async () => {
console.log("[YAFW] detectHardwareAccelerators called");
try {
const proc = Bun.spawn(["ffmpeg", "-encoders"], {
const proc = Bun.spawn([await ffmpegPathPromise, "-encoders"], {
stdout: "pipe",
stderr: "pipe",
});
Expand Down
Loading