Repository navigation
feat: allow custom base url - #254
Conversation
|
感谢 PR!把云端 API 基础地址做成 一点建议: 已批准 CI,并请 Codex 审查。 @codex review 🤖 Generated with Claude Code |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1cd4d3c9f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1cd4d3c to
98e6eb8
Compare
|
98e6eb8 看过:显式设置但无效的 @codex review 🤖 Generated with Claude Code |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 98e6eb8279
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
A login with UU_BASE_URL wrote only the token, so the host service the viewer restarts (started without the variable) sent the self-hosted token to the default NetEase API. Persist the address used as config base_url.
The base URL validation errors reached the login window in English only. Make them a typed error: Display keeps the English log text, localized() gives the window text. The login checks the setting before any request.
UU_BASE_URL in the systemd unit overrides the base_url saved at login, so a login against another server would send its token to the wrong one.
|
3baa29f/aedba39/d88e90f 看过:扫码登录成功后把所用地址写入配置 @codex review 🤖 Generated with Claude Code |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d88e90f31a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
d88e90f CI 全绿。Codex 新这条 P1 核实成立: 🤖 Generated with Claude Code |
A host waiting for credentials re-read the token but kept the base URL from the startup config snapshot, so a token issued by a self-hosted server was sent to the old address. Credentials now carry base_url from the same config read, and login always records the address it used.
|
c68409e 看过: @codex review 🤖 Generated with Claude Code |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Codex 复审 c68409e 无问题、CI 全绿,已 squash 合并,会随下个版本发布。感谢 @Moraxyc 多轮细致修改! 🤖 Generated with Claude Code |
支持自定义信令服务器和调度云的地址,这意味着我们有机会在完全自部署的环境下,摆脱对网易云服务的依赖,同时保留 UU 远程的完整功能。
目前,我正在尝试开发这样一套服务端:Remora。
幸运的是,UU 远程在很大程度上建立于开源组件和标准化技术之上。这为我们提供了一条相对直接的实现路径,不用大量的逆向工程或破解通信协议,也无需承担由此可能带来的法律风险,就有望实现完整功能的自部署方案。