Repository navigation
feat(packaging): consolidate packaging assets and add Nix flake/module - #258
Conversation
21f15ab to
e3b22e9
Compare
|
感谢!整理打包目录并加 Nix flake/模块的方向很好。初步审查:本地 几点小问题:
已请 Codex 审查,返回后再合并。 🤖 Generated with Claude Code |
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
After moving this README into packaging/docker, both ../docs/deploy-nas-docker.md links resolve under packaging/docs. A repository-wide rg --files search finds the deployment guide only at docs/deploy-nas-docker.md. Update both language sections to use ../../docs/deploy-nas-docker.md, preserving the English anchor, so readers can reach the deployment and first-login instructions.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
感谢快速跟进!新提交已核对:host 改为 libexec 下保留原名的二进制 + 带 再请 Codex 复审一次新提交,返回无问题后合并。 @codex review 🤖 Generated with Claude Code |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1a8c50bb5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Codex 对 f1a8c50 的复审返回 3 条 P2,已逐条核对源码,均成立:
修完后我再请一次复审,无问题即合并。谢谢! 🤖 Generated with Claude Code |
|
感谢跟进!新提交已核对,三条 P2 均已处理:
另外新增的 NixOS VM 测试( @codex review 🤖 Generated with Claude Code |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
已 squash 合并(1f01bad),感谢 @Moraxyc 的打包整合与 Nix flake/模块,以及按审查意见的多轮修改!将随下一个版本发布。 🤖 Generated with Claude Code |
packaging/common exists on main since VallierDev#258 moved the desktop entries and the systemd unit template there, so the transitional directory check can go and the staging steps match release.yml exactly.
Summary
添加nix相关打包,使得nixos用户可以更轻松地安装和使用uu-remote-linux。
同时为了减少重复代码,将systemd、udev和desktop相关的文件移动到
packaging/common目录下,docker相关文件移动到packaging/docker目录下,规范各发行版打包文件位置。Assisted-by: Gemini 4 Argon
packaging/common/:packaging/common/systemd/uuremote-native.service.in(@EXEC_START@template) as the single source of truth for.deb, the tarball installer, the Nix package, andsrc/viewer/host.rs(include_str!).packaging/common/udev/60-uu-remote-linux-uinput.rulessopackaging/deb/build-deb.shandpackaging/nix/package.nixno longer duplicate inline udev rule strings.contrib/desktop/(*.desktopanduu-remote-linux.svg) topackaging/common/desktop/and updatepackaging/deb/build-deb.sh,packaging/tarball/install.sh,.github/workflows/{ci,release}.yml,c_engine/assist_window.c,README.md,README.en.md, andAGENTS.md.packaging/docker/:docker/{Dockerfile,README.md,compose.yaml}underpackaging/docker/and update.github/workflows/release.yml(context: packaging/docker).flake.nix(packages.default/packages.uu-remote-linux,overlays.default,nixosModules.default,devShells.default,formatter) andflake.lock.packaging/nix/package.nixwith feature toggles (withWayland,withPortal,withViewer,withInprocAv) and narrowlib.fileset.toSource.packaging/nix/module.nix(services.uu-remote-linuxwithenable,package,ffmpegPackage,uinput.enable).flake.lockmanual refresh expectations inAGENTS.md(matching the repo's existing--lockedworkflow).