Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d5b6cfcbd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (pluginId === 'feishu' && canonicalFeishuId !== 'feishu') { | ||
| continue; |
There was a problem hiding this comment.
This guard skips re-adding bundled feishu whenever canonicalFeishuId !== 'feishu', but canonicalFeishuId falls back to FEISHU_PLUGIN_ID_CANDIDATES[0] even when no replacement plugin is actually installed/configured. In that case (for example, failed/missing ~/.openclaw/extensions install), the sanitize pass now removes feishu from plugins.allow and never adds it back, leaving users without any loadable Feishu plugin after restart. Please tie this skip to a confirmed replacement plugin presence (e.g., installed/configured) rather than the canonical fallback value alone.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 01a12fe117
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (!pEntries.feishu || (pEntries.feishu as Record<string, unknown>).enabled !== false) { | ||
| pEntries.feishu = { enabled: false }; |
There was a problem hiding this comment.
This assignment disables the built-in feishu extension whenever canonicalFeishuId !== 'feishu', but canonicalFeishuId still falls back to FEISHU_PLUGIN_ID_CANDIDATES[0] even when no replacement plugin is actually installed/configured. In that case, sanitize can write plugins.entries.feishu.enabled=false for users who only have unrelated plugin config, so if the later auto-install/upgrade step fails (it is best-effort and swallowed), Feishu has no loadable plugin at startup. Please only force feishu to disabled after a confirmed replacement plugin presence.
Useful? React with 👍 / 👎.
1 participant
No description provided.