Repository navigation
Harden identity checks, quiet the log, clean up - #49
Merged
Merged
Conversation
A finding ID points at notes the repository does not contain; the reason belongs in the line itself.
The sentences around them already give the reason; where one leaned on the ID, it now says what happened.
Leftovers from adopting the client, a wrong variant type, and comments whose setters, sizes and timings had changed.
Also refuse a non-text value for a text property instead of converting it with str().
The C loader parses it eight times faster; raw-message subscribers, async property callbacks and six enums had no user.
The guard missed whole files and ID shapes, and took hyphenated MAC addresses for IDs.
NOTICE says what became of utils and where connection.py came from; the change markers go, as the client no longer marks changes.
An entry keyed on its serial but still marked as awaiting one (a cloud entry made local by Reconfigure) kept the mark, so its client never checked the charger's identity.
Reauth and Reconfigure probed without the entry's serial, so another charger with another password was reported as a wrong password.
Each repeated per form probe, setup or reconnect cycle. A failing frame warns once per connection and names the line it failed at; the backoff starts over only once a connection got ready.
Any version named in the action was sent as is; with nothing on offer, installing the latest sent the installed version.
A disconnect error at unload left the entry at FAILED_UNLOAD until a restart. Setup and the form probe each swallowed it on their own; now the shutdown itself logs it.
The timed check ran over its limit under mutation testing.
A failing value or property callback warned on every frame and blamed the charger for an unreadable value; both catches now share the budget.
The flow tests ignored it, so a probe built with the wrong serial passed.
The rebuilt guard missed IDs with two digits, which its predecessor caught, flagged common standard names and read files git ignores.
Also spare common standard names and leave files git ignores alone.
Taking the expected serial over for good let a second attempt against the same other charger pass.
The frame's own catch warned just the same, so losing the per-value isolation went unnoticed. Also tighten three descriptions.
An empty list passed the guard unread, the fake knew the serial before hello, and a failing value was only tested in delta frames.
Addresses leave the line before the search, a one-digit number no longer counts, and a failed listing says it needs a checkout. The fake knows no serial until hello, as the client does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identity
Log
Other fixes
Cleanup