Repository navigation
Close the audit backlog: tests, guards and cleanups - #13
Merged
Merged
Conversation
Varitras
commented
Nov 1, 2026
Varitras
commented
Owner
- More tests for failure paths: a restore cut off mid-way, end of stream from the speaker, a failed platform setup, backup/discovery/EQ-reset timeouts.
- New guard: every error key the code hands out has a text.
- Standby minutes are durations.
- Write errors mapped in one place; the redundant poll priority flag is gone (the FIFO lock already serves user actions first).
- Relocate takes the serial a speaker announces and only asks speakers without one over TCP.
- Naming and code-standard cleanups; logo note dropped from the README.
With Any, strict mypy checked none of the coordinator calls; the store key was spelled out three times beside its owner.
LOCAL, rejected and unreachable were mapped by hand in three writers, and async_persist raised the same error from two branches.
The poll takes the client lock per path and asyncio.Lock is FIFO, so a waiting write already goes next; the flag only added a 50 ms pause.
Only candidates whose announcement carries no serial are asked over TCP; the next setup checks the serial against the device either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.