Skip to content

Fix the findings of the 2.1.1 audit - #25

Merged
Varitras merged 9 commits into
mainfrom
feature/audit-2026-10-30
Oct 30, 2026
Merged

Varitras merged 9 commits into
mainfrom
feature/audit-2026-10-30

Conversation

@Varitras

Copy link
Copy Markdown
Owner
  • A pump that stops answering (timeout, dropped link) is logged at info when
    its entities go unavailable, like its return; a refused band, a protocol
    error or a fault of this code stays an error.
  • The migration warning about two entries on one pump names them by entry
    id, not by title, which often holds the host.
  • The title capture reads a menu again that came with nothing to open,
    instead of asking for a number from 1 to 0.
  • The register scan refuses answers that do not fit the request (another
    function's answer, another byte count, another MEI type) instead of
    writing them into the CSV as readings.
  • Four statements in the README, the test guide, the capture starter and a
    docstring now match what the code does.

The first retry waits for the shortest page interval when that is longer,
the request guard admits the setting POST, the capture lands in the
working directory, and the web interface logs out after the unload.
Entry titles often hold the host, and logs are attached to issues.
Home Assistant logs every failed refresh at ERROR. A pump switched off or
a dropped link is expected; a refused band or a fault of this code stays
an error.
A menu that came with Service and Reset only left the capture asking for
a number from 1 to 0; it now counts as half and is read again.
An answer to another function, a register answer of another byte count
and an identification of another MEI type went into the CSV as readings.
The translation check knew the base error names only and missed a
subclass raised through a variable; the filter is added at setup, not
at import.
Picked by the user, it came back the same way in every attempt.
A band read that hangs stays an error; the web interface's stop, which
comes with its repair notice, is logged at info like a pump gone away.
The outage line names the kind of failure, as the library's text names
the host.
@Varitras
Varitras merged commit 6d3a6f8 into main Oct 30, 2026
10 checks passed
@Varitras
Varitras deleted the feature/audit-2026-10-30 branch October 30, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant