Repository navigation
Fixes of the 2026-10-31 audit - #28
Merged
Merged
Conversation
Varitras
commented
Nov 1, 2026
Varitras
commented
Owner
- Expected outages (pump unreachable, web interface paused) follow the log level like their recovery line: hidden at Home Assistant's default level, both shown at info or debug.
- After the web interface's polling resumes from a stop, every page is read at once instead of after its own interval.
- Migration removes the legacy web-interface login keys (and the upstream 2.0 line's MAC) whatever the entry version, and removes the empty 1.x web-interface devices. Diagnostics show only the integration's own keys.
- CI runs the mutation step by a matrix key instead of the job name.
- The capture and scan tools strip spaces around the address.
- Stale comments in the guard configuration corrected.
The filter lowers the record after the logger checked it against ERROR, so at Home Assistant's default WARNING the outage showed while its recovery did not.
The stop wipes all values, but a page with an hourly interval waited out the hour from its last request, unavailable although polling had resumed.
The upstream 2.0 line wrote version 9 with the web-interface login and a MAC address, which survived migration and showed in diagnostics. Diagnostics now show only known keys, and the empty 1.x web-interface devices are removed.
Renaming the job silently skipped every mutation case.
Setup recreates a removed pump device under its old id, so the test now watches the registry's removal events.
Releases before migrated the entry and left them behind; the migration alone never reached such an entry again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.