Vite 6 to 8, plugin-react 4 to 6, lucide-react 0.577 to 1.7 (supersedes #13, #12, #11) - #17
Merged
Merged
Conversation
Dependabot opened these as three separate pull requests and two of them failed CI, which reads as "the majors are unsafe". They are not: taken together they build. @vitejs/plugin-react 4 does not support Vite 8, so each bump fails without the other and passes with it. Verified on this machine: 2,462 modules transformed, build clean. That build also surfaced a defect nobody could see from the source. src/index.css opened with `@import "tailwindcss"` and put the Google Fonts import on the line after it. Tailwind's import expands to rules, and an @import that follows a rule is invalid and is dropped, so Inter and Poppins never loaded and the site rendered in a system fallback. The font import is first now; the compiled stylesheet grows by 70 bytes, which is the rule that used to be discarded. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MrvR2NXsJFVRCeJZFCPuNL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Dependabot opened these three as separate pull requests and two of them failed CI, which reads as "these majors are unsafe". They are not.
@vitejs/plugin-react4 does not support Vite 8, so each bump fails without the other and passes with it. Taken together they build: verified on this machine, 2,462 modules transformed, build clean, output 650 kB JS and 46 kB CSS.That is why #12 and #11 are red and #13 is green, and why merging them one at a time would have broken
main.The build also surfaced a defect that is invisible in the source.
src/index.cssopened with@import "tailwindcss"and put the Google Fonts import on the line after it. Tailwind's import expands to rules, and an@importthat follows a rule is invalid and is dropped — so Inter and Poppins never loaded and the site rendered in a system fallback. Vite 8's CSS optimizer says so out loud where Vite 6 did not. The font import is first now, and the compiled stylesheet grows by exactly the rule that used to be discarded.Supersedes #13, #12 and #11.
Type of change
Checklist
npm installthennpm run buildclean on Node 22.22.2🤖 Generated with Claude Code
https://claude.ai/code/session_01MrvR2NXsJFVRCeJZFCPuNL
Generated by Claude Code