Repository navigation
Fix: make data build deterministic so CI validation passes - #7
Merged
Merged
Conversation
The build wrote a calendar date (`generatedAt`) into stats.json, which made `npm run validate` (the CI `--check` step) fail on any day after the file was generated — it saw the regenerated date as data drift. Remove the timestamp so the build output depends only on the study data, and drop the date from the insights-panel note that displayed it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012msh1nNMxadJd417S8FjP2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up bug fix to the modernization in #6. The new data-validation CI job failed on
mainafter the merge because the build was not deterministic.Type of Change
Related Issue
Closes #
Changes Made
scripts/build.mjswrote a calendar date (generatedAt) intodata/stats.json. On any day after the file was generated,npm run validate(the CI--checkstep) regenerated a different date and reported it as data drift, failing CI. Removed the timestamp so the generated output depends only on the study data.js/app.jsthat displayedgeneratedAt.data/stats.json.Testing
npm run validatenow passes independent of the date; the insights dashboard renders with no console errors.Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_012msh1nNMxadJd417S8FjP2
Generated by Claude Code