Release 0.8.3 - #63
Merged
Merged
Conversation
Two fixes, one found by a contributor and one found by using the thing. Game titles with non-ASCII characters were mangled: text=True decodes with the locale default, cp1252 on a stock Windows install, while Ludusavi and rclone emit UTF-8. Found by @Tudzer in #60, who fixed the Ludusavi call. Five others had the same defect, and rclone's mattered most - a game id keeps the non-ASCII from its title and an id is part of the remote path, so a mangled listing is retention and restore reading the wrong paths. Removing a game now sticks. `gsg remove --purge` deleted a game and its backups and the next scan added it straight back, because nothing recorded the removal and a launcher-owned game only stays skipped while its launcher reports it installed (#61).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes: one found by a contributor, one found by using the thing.
#60 — non-ASCII game titles were mangled.
text=Truedecodes with the locale default, cp1252 on a stock Windows install, while Ludusavi and rclone emit UTF-8. Found and fixed by @Tudzer in the Ludusavi call.Five other subprocess calls had the same defect. rclone's mattered most — a game id keeps whatever non-ASCII its title had, and an id is part of the remote path, so a mangled listing is retention and restore reading the wrong paths rather than a cosmetic wrong name. A test now fails if any subprocess call is added without an explicit encoding.
#61 — removing a game now sticks.
gsg remove --purgedeleted a game and its backups and the next scan added it straight back, because nothing recorded the removal and a launcher-owned game only stays skipped while its launcher reports it as installed. Removals are remembered,gsg addun-remembers them, and the scan says what it is skipping rather than suppressing silently.Changes here
0.8.2→0.8.3inpyproject.tomland__init__.py, plus the changelog. The fixes merged as #60 and #62.Verified:
gsg --versionreports 0.8.3, 336 tests pass, ruff and mypy clean,check_deps.pyconfirms all 13 runtime dependencies declared.