feat(market): add validation TODO and fix withdraw test auth issue#194
Open
intelliDean wants to merge 1 commit into
Open
feat(market): add validation TODO and fix withdraw test auth issue#194intelliDean wants to merge 1 commit into
intelliDean wants to merge 1 commit into
Conversation
Contributor
|
@intelliDean please resolve conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR addresses the onboarding task described in issue #92 to add a TODO with a GitHub issue link near the validation helpers.
Proposed Changes
TODO(#77)referencing issue [contracts] Refactor validation helpers for readability #77 near the validation helpers incontracts/market/src/validation.rs.contracts/market/src/withdraw.rsunit tests whereenv.mock_all_auths()was set up aftertoken_client.mintwas already called, causing authentication failure. Moving it to the start of the test allows all 93 unit tests to pass successfully.Verification
cargo test).Closes #92