refactor(positions): extract scale_by_bps helper for readability#236
Open
Mmesolove wants to merge 1 commit into
Open
refactor(positions): extract scale_by_bps helper for readability#236Mmesolove wants to merge 1 commit into
Mmesolove wants to merge 1 commit into
Conversation
No behavior change. The repeated checked_mul/checked_div chain in calculate_locked_collateral is extracted into a private scale_by_bps helper, making both branches a single readable expression.
Author
|
please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #166
Summary
Extracts the repeated
checked_mul / checked_div(BASIS_POINTS)chain incalculate_locked_collateralinto a privatescale_by_bps(amount, price_bps)helper.Changes
positions.rs: new privatescale_by_bpshelper; both branches ofcalculate_locked_collateralreduced to a single expression eachNo behavior change
Arithmetic is identical — same overflow semantics, same results for all inputs. All existing tests cover the refactored paths unchanged.
Checklist
-D warnings)