This repository was archived by the owner on Sep 15, 2026. It is now read-only.
Separate installation and provider health checks - #50
Merged
Merged
Conversation
|
VdustR
marked this pull request as ready for review
September 2, 2026 03:17
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Let transactional updates validate the installed services and state contract without rolling back on a temporary external CodexBar timeout. The regular
doctorcommand remains a strict full provider-health check.Closes #49
Problem
A valid local update reached the final doctor step, but
codexbar usage --provider codex --format jsonexceeded the fixed 20-second collection timeout. The installer rolled back the working update even though the bridge, renderer, and state endpoint were healthy. Direct provider calls took 21.89 seconds and more than 34.60 seconds.Change
doctor --installation-onlyfor LaunchAgent, bridge identity, native renderer heartbeat, CodexBar executable, and/api/v1/stateschema validation.doctormode strict about sessions and required Codex usage.Verification
doctor --installation-only, and a slow Codex provider forces installer rollback.StateStoreor starts provider collection.PYTHONPATH=src python3 -m unittest discover -s tests -v— 74 tests passedpyright src tests— 0 errorspython3 -m compileall -q src testsswift test --package-path native— 9 tests passedgit diff --checkValidation boundary
Unit and contract tests verify the split health gates. The real transactional update and process-cadence readback will run on the affected Mac after merge.