This repository was archived by the owner on Sep 15, 2026. It is now read-only.
Wait for renderer LaunchAgent before upgrade bootstrap - #53
Merged
Merged
Conversation
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Fixes a device-verified upgrade race where
launchctl bootstrapreturned I/O error while the prior renderer job was still unloading.Follow-up for #51.
Changes
launchctl printto confirm the old renderer job is absent before bootstrapping the replacement.Verification
PYTHONPATH=src python3 -m unittest tests.test_scriptsbash -n scripts/install-renderer.shgit diff --checkDevice evidence
The first merged upgrade rolled back safely after
launchctl bootstrapreturned exit 5. Current jobs and the previous app were restored. This PR addresses the observed transition before retrying the upgrade.