Skip to content
This repository was archived by the owner on Sep 15, 2026. It is now read-only.

Normalize renderer login preference for launchd - #54

Merged
VdustR merged 1 commit into
mainfrom
codex/issue-51-renderer-login-boolean
Sep 2, 2026
Merged

VdustR merged 1 commit into
mainfrom
codex/issue-51-renderer-login-boolean

Conversation

@VdustR

@VdustR VdustR commented Sep 2, 2026

Copy link
Copy Markdown
Owner

TL;DR

Fixes device-verified Open at Login drift where the renderer plist received false while the bridge plist and persisted preference were true.

Follow-up for #51.

Cause

The installer passed 1 or 0 directly to plutil -bool. The bridge parser treated 1 as true, but plutil did not, leaving the two LaunchAgents inconsistent.

Changes

  • Normalize 1/true to the plist boolean true.
  • Normalize 0/false to the plist boolean false.
  • Reject invalid preference values.
  • Cover both mappings and the normalized plist write in script tests.

Verification

  • PYTHONPATH=src python3 -m unittest tests.test_scripts
  • bash -n scripts/install-renderer.sh
  • git diff --check

Device evidence

Before this fix, the persisted preference was 1, bridge RunAtLoad was true, and renderer RunAtLoad was false after a successful upgrade. After merge, the target Mac will be reinstalled and both plist values read back.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T04:28:56.767283Z 1d20114 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@VdustR
VdustR merged commit c1cb7e4 into main Sep 2, 2026
1 check passed
@VdustR
VdustR deleted the codex/issue-51-renderer-login-boolean branch September 2, 2026 04:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant