Skip to content
This repository was archived by the owner on Sep 15, 2026. It is now read-only.

Cover Touch Bar dismiss capability fallback - #55

Merged
VdustR merged 1 commit into
mainfrom
codex/issue-51-dismiss-fallback-test
Sep 2, 2026
Merged

VdustR merged 1 commit into
mainfrom
codex/issue-51-dismiss-fallback-test

Conversation

@VdustR

@VdustR VdustR commented Sep 2, 2026

Copy link
Copy Markdown
Owner

TL;DR

Adds the missing automated coverage for the private dismiss API fallback required by issue #51.

Changes

  • Extract Touch Bar default item selection into a pure helper.
  • Verify the close control is included when dismiss is supported.
  • Verify only content remains when dismiss is unavailable.

Verification

  • swift test --package-path native
  • PYTHONPATH=src python3 -m unittest discover -s tests
  • pyright src tests
  • git diff --check

@changeset-bot

changeset-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c0c9ef5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T04:32:53.278591Z c0c9ef5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@VdustR
VdustR merged commit c932c8e into main Sep 2, 2026
1 check passed
@VdustR
VdustR deleted the codex/issue-51-dismiss-fallback-test branch September 2, 2026 04:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant