Stop unmanaged renderer processes during upgrade - #56
Conversation
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb81cd35f7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 078d5e71cb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
TL;DR
Prevents duplicate Agent Touch Bar renderers when upgrading after the app was launched manually from Spotlight.
Follow-up for #51.
Cause
A manually launched renderer is not owned by the renderer LaunchAgent. Upgrade booted out the LaunchAgent but did not terminate that independent process before bootstrapping a new managed renderer.
Changes
agent-touchbar-hostprocesses.Verification
./scripts/install.sh; renderer process count changed from two to exactly one.agent-touchbar doctor --installation-onlypasses.PYTHONPATH=src python3 -m unittest tests.test_scriptsbash -n scripts/install-renderer.sh scripts/uninstall.shgit diff --check