Skip to content
This repository was archived by the owner on Sep 15, 2026. It is now read-only.

Stop unmanaged renderer processes during upgrade - #56

Merged
VdustR merged 3 commits into
mainfrom
codex/issue-51-unmanaged-renderer-upgrade
Sep 2, 2026
Merged

VdustR merged 3 commits into
mainfrom
codex/issue-51-unmanaged-renderer-upgrade

Conversation

@VdustR

@VdustR VdustR commented Sep 2, 2026

Copy link
Copy Markdown
Owner

TL;DR

Prevents duplicate Agent Touch Bar renderers when upgrading after the app was launched manually from Spotlight.

Follow-up for #51.

Cause

A manually launched renderer is not owned by the renderer LaunchAgent. Upgrade booted out the LaunchAgent but did not terminate that independent process before bootstrapping a new managed renderer.

Changes

  • After unloading the renderer job, terminate remaining user-owned agent-touchbar-host processes.
  • Wait up to five seconds for manual renderers to exit before bootstrap.
  • Apply the same cleanup during uninstall.
  • Cover cleanup ordering and uninstall behavior in script tests.

Verification

  • Created the real duplicate state with one manual and one managed renderer.
  • Re-ran ./scripts/install.sh; renderer process count changed from two to exactly one.
  • agent-touchbar doctor --installation-only passes.
  • PYTHONPATH=src python3 -m unittest tests.test_scripts
  • bash -n scripts/install-renderer.sh scripts/uninstall.sh
  • git diff --check

@changeset-bot

changeset-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9e69093

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T04:49:20.445604Z 9e69093 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fb81cd35f7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/install-renderer.sh Outdated
Comment thread scripts/install-renderer.sh Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 078d5e71cb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/install-renderer.sh Outdated
@VdustR
VdustR merged commit fc7ec48 into main Sep 2, 2026
1 check passed
@VdustR
VdustR deleted the codex/issue-51-unmanaged-renderer-upgrade branch September 2, 2026 04:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant